Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #988, run inverse search command as separated command and args #989

Merged
merged 2 commits into from
Feb 28, 2024
Merged

fix #988, run inverse search command as separated command and args #989

merged 2 commits into from
Feb 28, 2024

Conversation

jinjiaodawang
Copy link
Contributor

fix #988, run inverse search command as separated command and args

@ahrm
Copy link
Owner

ahrm commented Feb 28, 2024

Does this work if inverse_search_command contains spaces in the command itself? (e.g. in my configuration on windows I manually have the path to vscode command which contains spaces, something like: "Path to vscode.exe" -r -g "%1":%2).

@jinjiaodawang
Copy link
Contributor Author

It depends on the implementation of QProcess::splitCommand. I hadn't considered the scenario you mentioned. So, in your case, does "Path to vscode.exe" run as the executable?

@ahrm
Copy link
Owner

ahrm commented Feb 28, 2024

I tested it and it does seem to work. Thanks :) .

@ahrm ahrm merged commit ed77c64 into ahrm:development Feb 28, 2024
1 of 6 checks passed
@jinjiaodawang
Copy link
Contributor Author

jinjiaodawang commented Feb 28, 2024

The source code of QProcess::splitCommand seems considered the scenario you mentioned, life is good. ^^
edit: you may close the issue #988

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants